This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: typedef fileline location_t
Zack Weinberg wrote:
The problem with this is you're going to have to change them all again
if you ever add column information.
I don't see anything terribly wrong with using 'fileline' to also
provide column numbers. (It also provides include file context.)
May I suggest 'srcloc_t' or
'struct srcloc' which are unambiguous about what kind of location, but
avoid indicating exactly what is recorded?
I have no problem with 'srcloc'. I don't think we should add the '_t'.
We don't for most other gcc typedefs including 'tree' or 'rtl'. Also,
Posix.1 reserves identifiers ending with '_t' to the implemenation.
In practive Gcc is part of the implementation - but for the target,
not the host.
--
--Per Bothner
per@bothner.com http://per.bothner.com/