Re: [PATCH] Yet another tree dumper

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

Dale Johannesen <dalej@apple.com> writes:

| On Friday, October 10, 2003, at 11:17  AM, Jason Merrill wrote:
| > On Fri, 10 Oct 2003 09:43:11 -0700, Dale Johannesen
| > <dalej@apple.com> wrote:
| > On Thursday, October 9, 2003, at 07:57  PM, Jason Merrill wrote:
| >
| >>> This doesn't seem like a significant enough improvement to justify
| >>> duplicating so much code.
| >>
| >> As an experienced user of both dumpers, I find the second one is FAR
| >> superior.
| >
| > Why?  The example Devang gave looks just as messy as the current
| > dumper,
| > and doesn't have the <> brackets to mark boundaries.
| 
| Why.  OK, I'm not that good at "why", but here's some things that
| stand out:
| Less type information,  unless you ask for it (this is generally
| useless to me)
| Indentation works better, so you can follow the structure better
| debug_tree often stops too soon, before it's gotten to what I'm
| interested in

Those are sensible reasons.  However, I would suggest you add 
parameters to the existing tree dumper; in particular, tha would cover
your remark:

| This sort of thing comes down to personal preference; I'm not
| suggesting eliminating
| the old one, if there are those who prefer it.  Presumably Gaby wasn't
| happy with
| it, though...

I wasn't happy more from engineering point of than from personal
preference.  In particular, the old pretty-printer got into, ahem, a
spaghetti code and adding new functionalities was being more difficult
than it should be.  

| > Also, have you tried the pretty-printer on the tree-ssa branch?
| 
| No.  We should look at that.  (It does work on non-ssa form?  Won't
| help otherwise.)

Yes, it does.  

-- Gaby