This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa-cfg] BIND_EXPR removal



On Oct 7, 2003, at 2:03 PM, Zdenek Dvorak wrote:


Hello,

nope, both problems I have detected should also be on mainline. The
first is the dom_children allocated by gc (this I fixed). The second
one is that dominance_info structure contains varray that is also
allocated by gc. Both of these cause problems when dominators are
recomputed,

I should also note that once Andrew fixes the remaining critical edge
splitting bugs, so i can pre-split critical edges in PRE, we won't be
needing to recompute dominators anymore in SSAPRE, so the problem goes
away.

what are these problems?

Fun with splitting edges that belong to switch statements and whatnot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12529 for the latest one.


Or, try changing the #if 0 in split_critical_edges in tree-ssa-pre.c to
#if 1, and see if it bootstraps.

OK, testing the attached patch.

It seems you discovered the other reason i want to do it: Removal of ugly ass code.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]