This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] renesas abi and optimize mode switching


On Oct  2, 2003, Eric Christopher <echristo@redhat.com> wrote:

> OK? Changes? Other thoughts?

As far as I'm concerned, this is ok, but I'm not sure I'm entitled to
approve changes for optimize_mode_switching, even though SH is the
only user of this feature.  Am I?

> +#define MODE_EXIT(ENTITY) (sh_cfun_attr_renesas_p () ? FP_MODE_NONE :
> NORMAL_MODE (ENTITY))

When I suggested you to add a line break here, I didn't mean a line
break in the patch file, but rather in the source file :-)

How about:

+#define MODE_EXIT(ENTITY) \
+  (sh_cfun_attr_renesas_p () ? FP_MODE_NONE : NORMAL_MODE (ENTITY))

Thanks.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]