This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATH] PR C++/12047
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 28 Sep 2003 18:04:17 -0700
- Subject: Re: [PATH] PR C++/12047
- Organization: CodeSourcery, LLC
- References: <20030928091519.GA1296@kam.mff.cuni.cz>
On Sun, 2003-09-28 at 02:15, Jan Hubicka wrote:
> Hi,
> this is apparently another missing mark_used on eh type. I remember
> myself adding this one already, but apparently it got lost. OK?
That change should be OK. Used-ness just means that the thing appeared
in the program -- not that it was actually emitted.
However, instead of build1 (ADDR_EXPR, ...) that code should be using
build_address. (One key benefit is that this will set TREE_CONSTANT on
the ADDR_EXPR if appropriate, which it may well be in this case.)
Your patch is OK, but if you can test the build_address change as well
that would be better.
--
Mark Mitchell <mark@codesourcery.com>
CodeSourcery, LLC