This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Clean up with-cpu clauses in config.gcc
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Wed, 24 Sep 2003 00:16:21 -0400
- Subject: Re: [patch] Clean up with-cpu clauses in config.gcc
- References: <20030924025744.GA3431@twcny.rr.com>
On Tue, Sep 23, 2003 at 10:57:44PM -0400, Nathanael Nerode wrote:
> The following points needed to be fixed:
> 1. Since separation of config.host and config.build, all of this has
> been indented at least one tab too far.
> 2. The old indentation style is painful to read anyway, and did not match
> the majority of the shell scripts in GCC.
> 3. Use of the "x$foo" model in case statements is unnecessary.
> 4. There was a completely redundant case statement (selecting on $target)
> underneath the target=alpha-*-* clause in the main case statement. If this
> was meant to select on $target_alias or some such, do tell. :-)
No, that looks right. I pulled it out of somewhere larger, where the
extra case was useful. Patch looks right to me.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer