This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFT] libffi reorg (take 3)

> Ok, below I think the logic is wrong, at least with the LONG_LONG_MAX.

In theory, yes; or alternatively remove the #else line.  The problem is that
on my machine it is actually correct this way because LONG_LONG_MAX is not
defined!   In general, it is dangerous because __STRICT_ANSI__ disables it.

The correct solution is to include a snippet like this

#ifdef LONG_LONG_MAX
# define FFI_LONG_LONG_MAX LONG_LONG_MAX
#else
# ifdef LLONG_MAX
#  define FFI_LONG_LONG_MAX LLONG_MAX
# else
#  ifdef __GNUC__
#   define FFI_LONG_LONG_MAX __LONG_LONG_MAX__
#  endif
# endif
#endif

> Second, the darwin assembler doesn't like this:

And it has all the right :-)  There is a similar problem in IA-64.

Paolo

Attachment: libffi-reorg-patch-3.diff
Description: Binary data

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]