This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to update builtins.c:builtin_mathfn_code()
> From: Jim Wilson <wilson@specifixinc.com>
>
> Kaveh R. Ghazi wrote:
> > * builtins.c (builtin_mathfn_code): Generalize to process builtins
> > with any REAL_TYPE or COMPLEX_TYPE arguments.
>
> OK.
After some offline discussion with Roger, I feel he has a better
approach for detecting math builtin codes which he posted here:
http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00771.html
(As explained in the posting, Roger's patch catches parameter
mismatches, and it should work with _any_ builtin, not just math
ones. This makes it a better long term solution as it will allow
simplifying other parts of the builtins framework.)
Therefore I'm withdrawing my patch in favor of his. Thanks Jim for
your review, sorry you had to look at my less than pefect approach,
perhaps you could review Roger's patch instead?
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu