This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Zone allocating collector review



On Sun, 14 Sep 2003, Daniel Berlin wrote:

>
> > Lots of comments, in no particular order:
> >
> > - The changes to ggc.h add new parameters to the PCH routines but do
> >   not change the comments.  Please fix this, those comments are the
> >   only documentation for these routines.
>

I'd just like to note here that the 2/3rds of the functions i've
changed don't document all the parameters right now
(ggc_pch_write_object, ggc_pch_alloc_object).

One in fact, doesn't document any of the parameters
(ggc_pch_write_object), and it's not obvious at all why there are two
void *'s.

So if these comments are the only documentation for these routines, this
is a sad state of affairs.
I was under the impression they were also described somewhere else, but
apparently not.

--Dan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]