Re: Ping^2: [patch] convert some call ABI macros to hooks, apply to sh, add bitfield swapper

[Richard Henderson <rth at redhat dot com>]

On Fri, Aug 29, 2003 at 06:38:24PM -0400, DJ Delorie wrote:
> http://gcc.gnu.org/ml/gcc-patches/2003-08/msg00815.html

Mostly ok.

+ 	fprintf(stderr, "\n-- aggregate_value_p --\n");
+ 	debug_tree (fntype);
+ 	break;

Left some debugging in.

-    Copyright (C) 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998
+    Copyright (C) 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2003
     1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.

Emacs copyright brokenness.


+   if ((* targetm.ms_bitfield_layout_p) (rli->t)
+       && (* targetm.reverse_bitfield_layout_p) (rli->t)
+       && ! TYPE_PACKED (rli->t))
+       reverse_bitfield_layout (rli);

Why would ms_bitfield_layout_p or TYPE_PACKED have anything
necessarily to do with reverse_bitfield_layout_p?  Seems like
these tests, if needed, should be pushed down into the 
reverse_bitfield_layout_p predicate.


r~