Re: m68k patch reviews (Was: m68k - Dropping the Motorola syntax)

[Bernardo Innocenti <bernie at develer dot com>]

On Friday 15 August 2003 10:09, Gunther Nikl wrote:

>  Since you can now contribute to GCC, could you please take care of:

sources.redhat.com is up again (it was a short outage after all :),
so I can now review these patches:


>    http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01666.html

This is obviously good.

>    http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01667.html

Looks fine to me.

>    http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01668.html

Are you sure all non-GAS assemblers behave the same way?
I'm sure that on all Amiga assemblers, the "moveq" instruction
defaulted to '.l' when size was omitted because it's the only
supported size, as opposed to "move" that defaulted to '.w'.

Anyway, I really like your patch because it improves
readability quite a lot. In case of doubt, we could reverse
it to keep the versions with "moveq%.l", which GAS likes anyway.


>    http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01675.html

This is trivially correct.

Thank you very much for this. Given the current m68k status,
I appreciate any effort aiming at complexity/LoC reduction much
more than adding  new features. I will be glad to review more
patches from you if you'd like to Cc me (I don't follow
the gcc-patches ml very closely).

Richard, could you please approve these patches so I'll
be able to commit them as soon as my CVS account is enabled?

-- 
  // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/

Please don't send Word attachments - http://www.gnu.org/philosophy/no-word-attachments.html