This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: change #if to #ifdef in gthr-win32.h
- From: Danny Smith <dannysmith at clear dot net dot nz>
- To: gnustuff at thisiscool dot com
- Cc: gcc-patches at gcc dot gnu dot org, awlaframboise at aol dot com,Christopher Faylor <cgf at redhat dot com>
- Date: Mon, 30 Jun 2003 11:11:35 +0100
- Subject: Re: Patch: change #if to #ifdef in gthr-win32.h
- References: <GCJF1NM521951YOKB7E9WROPZUC0.3effc908@p733>
- Reply-to: Danny Smith <dannysmith at users dot sourceforge dot net>
----- Original Message -----
From: "Mohan Embar" <gnustuff@...>
> Danny,
>
> I can't bootstrap a MingW32 3.4 compiler under Linux
> using gcc 3.2 20020903 unless I change #if to #ifdef
> in the following patch. Does this seem okay?
>
> -- Mohan
> http://www.thisiscool.com/
> http://www.animalsong.org/
>
> ChangeLog
> 2003-06-29 Mohan Embar <gnustuff@....>
>
> * gthr-win32.h: changed #if __GTHREAD_HIDE_WIN32API to
> #ifdef __GTHREAD_HIDE_WIN32API
>
No, the patch to grthr-win32.c, submitted by Aaron W. LaFramboise
http://gcc.gnu.org/ml/gcc-patches/2003-06/msg03116.html
does the right thing and fixes the regression. I inadvertantanyly
failed to check in my changes to gthr-win32.c when committed my
2003-05-21 patch to gthr-win32.h and to mingw's os_defines.h in
libstdc++. Aaron's patch corrects that.
(Chris, I just noticed however, that the ChangeLog entry for Aaron's
patch is wrong: it refers to config/i386/mingw32.h)
We want
#define __GTHREAD_HIDE_WIN32API 0
to be meaningful so that users can still overide the default when
compiling C++ code.
Danny