This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Another location_t cleanup
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 27 Jun 2003 09:26:25 -0700
- Subject: Re: [PATCH] Another location_t cleanup
- References: <3EFC50B1.9040909@codesourcery.com>
Nathan Sidwell <nathan@codesourcery.com> writes:
> * c-parse.in (%union): Replace filename & lineno with location.
> (save_filename, save_lineno): Remove.
> (save_location): New.
> (fndef, old_style_parm_decls_1, lineno_datadecl, lineno_decl,
> nested_function, notype_nested_function, if_prefix, lineno_stmt,
> lineno_label, label): Adjust.
Looks good except for one thing:
> /* The forced readahead in here is because we might be at the end of a
> line, and the line and file won't be bumped until yylex absorbs the
> ! first token on the next line. Must be balanced with a call to unsave_loc */
What's this "unsave_loc"? I can't find it either elsewhere in this
patch or anywhere in the source tree.
zw