This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Stripped down unit-at-a-time fix


> On Sun, Jun 22, 2003 at 12:23:44AM +0200, Jan Hubicka wrote:
> > + cgraph_node_for_identifier (id)
> > +      tree id;
> > + {
> > +   struct cgraph_node **slot;
> > + 
> > +   if (TREE_CODE (id) != IDENTIFIER_NODE)
> > +     abort ();
> > + 
> > +   if (!cgraph_hash)
> > +     {
> > +       cgraph_hash = htab_create (10, hash_node, eq_node, NULL);
> > +       VARRAY_TREE_INIT (known_fns, 32, "known_fns");
> > +     }
> 
> Same comment here wrt returning NULL.  I find it unlikely that
> creating the data structures here is useful.
I see now what you are shooting for :) too much cut-and-pasting 

Thanks!
Honza
> 
> The rest of it looks ok.
> 
> 
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]