Re: [patch] Fix PR debug/4252

[Neil Booth <neil at daikokuya dot co dot uk>]

Bob Abeles wrote:-

> Thank you for walking me through my first gcc patch; I appreciate your 
> taking the time to help me. I've bootstrapped with 
> enable-languages=c,c++,java and confirmed that the -fdump- family of 
> command-line flags work as expected. Here's my (hopefully) final patch:

Great, thanks.

> 	PR debug/4252
> 	* c-opts.c (c_common_handle_option): Pass -fdump argument suffix
> 	to dump_switch_p().
> 	* java/lang.c (java_handle_option): Likewise.
> 	* tree-dump.c (dump_switch_p): Remove redundant 'dump-' prefix
> 	from static strings in dump_files.
> 	* cp/optimize.c (dump_function): Form complete flag name by
> 	prefixing 'fdump-' to string returned by dump_flag_name().

Like Alexandre said, if java/ and cp/ didn't have their own Changelogs
(like e.g. doc/ doesn't) this would be the correct ChangeLog.  However,
in this case something like

	PR debug/4252
	* c-opts.c (c_common_handle_option): Pass -fdump argument suffix
	to dump_switch_p().
	* tree-dump.c (dump_switch_p): Remove redundant 'dump-' prefix
	from static strings in dump_files.
cp:
	* optimize.c (dump_function): Form complete flag name by
	prefixing 'fdump-' to string returned by dump_flag_name().
java:
	* lang.c (java_handle_option): Likewise.

is what we like.  Like he also said, you might consider putting -p
in your diff command, or having a .cvsrc similar to mine:

	diff -u -p -N
	update -d -P
	cvs -q -z6

The patch is fine; I'll apply it now.

Neil.