Re: PATCH: gcc.dg testsuite cleanups

[Andreas Tobler <toa at pop dot agri dot ch>]

Mark Mitchell wrote:

> You'll have to ask a Darwin expert.
>
> It looks like Darwin sort-of supports weak symbols, or the other weak
> tests would probably have failed as well.
>
> It may be that weak-3.c and 20000419-2.c should have "dg-require-alias"

[titanium:testsuite/gcc.dg/weak] andreast% cvs diff -u weak-3.c
Enter passphrase for RSA key '/Users/andreast/.ssh/identity':
Index: weak-3.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/gcc.dg/weak/weak-3.c,v
retrieving revision 1.2
diff -u -r1.2 weak-3.c
--- weak-3.c    6 Jun 2003 21:34:41 -0000       1.2
+++ weak-3.c    9 Jun 2003 16:47:27 -0000
@@ -1,5 +1,5 @@
-/* { dg-require-weak "" } */
 /* { dg-do compile } */
+/* { dg-require-weak "" } */
 /* { dg-options "-fno-common" } */

gives:

Running /Volumes/xufs/gcc-cvs/gcc/gcc/testsuite/gcc.dg/weak/weak.exp ...

                === gcc Summary ===

# of unresolved testcases       10
# of unsupported tests          10

RCS file: /cvs/gcc/gcc/gcc/testsuite/gcc.dg/special/20000419-2.c,v
retrieving revision 1.2
diff -u -r1.2 20000419-2.c
--- 20000419-2.c        5 Jun 2003 22:18:54 -0000       1.2
+++ 20000419-2.c        9 Jun 2003 16:49:23 -0000
@@ -1,7 +1,7 @@
 /* A static function with a global alias should not get 'defined but
    not used' warnings.  Exposed by Linux kernel.  */
 /* { dg-do compile } */
-/* { dg-require-alias } */
+/* { dg-require-alias "" } */
 /* { dg-options "-Wall" } */

RCS file: /cvs/gcc/gcc/gcc/testsuite/gcc.dg/special/weak-2.c,v
retrieving revision 1.4
diff -u -r1.4 weak-2.c
--- weak-2.c    5 Jun 2003 22:18:54 -0000       1.4
+++ weak-2.c    9 Jun 2003 16:49:23 -0000
@@ -1,4 +1,5 @@
 /* { dg-do run } */
+/* { dg-require-weak "" } */
 /* { dg-additional-sources "weak-2a.c weak-2b.c" } */

gives:
Running 
/Volumes/xufs/gcc-cvs/gcc/gcc/testsuite/gcc.dg/special/special.exp ...

                === gcc Summary ===

# of unresolved testcases       4
# of unsupported tests          8

Otherwise I get this error:

/Volumes/xufs/gcc-cvs/gcc/gcc/testsuite/gcc.dg/special/weak-2a.c:1: 
warning: weak declaration of `foo' not supported^M


Andreas