This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch installed for format specifier warnings
> From: Richard Earnshaw <rearnsha@arm.com>
>
> > > asm_fprintf supports %wd for printing a HOST_WIDE_INT. Why not use that
> > > instead of casting down?
> > > R.
> >
> > I'm sure you are aware in the general case, when *printf parameters
> > derive from arguments to the containing macro itself (like above),
> > they need to be casted no matter what because if the macro is used in
> > more than one place, you may get e.g. a long "SIZE" in one place and
> > an int "SIZE" in another.
> >
>
> Hmm, a fair point. I guess this can wait until these routines get pulled
> into the machine vector (or whatever it's called).
You mean `target hooks'?
> > Shall I install this?
>
> I've no objection if you want to, but on reflection I don't think it's
> necessary. An int cast should be good enough for these cases.
> R.
I'll just leave it alone then.
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu