This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH to decl.c: Factor debug code
- From: Jason Merrill <jason at redhat dot com>
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gdr at integrable-solutions dot net
- Date: Fri, 30 May 2003 14:46:46 -0400
- Subject: Re: C++ PATCH to decl.c: Factor debug code
- References: <20030530122812.72b20a3a.bkoz@redhat.com>
On Fri, 30 May 2003 12:28:12 -0500, Benjamin Kosnik <bkoz@redhat.com> wrote:
>> These two names sound odd to me; I'd say cxx_make_scope or make_cxx_scope,
>> and initial_push_namespace_scope. Also, the latter needs a comment.
>
> Huh. I'd thought the same thing when I read this patch.
>
> ... or maybe push_initial_namespace_scope and make_cxx_scope? Most
> functions seem to be named with the active verb as the first bit, at
> least that is the active convention that I'm pushing in the runtime.
In the case of "cxx_make_scope", the "cxx" modifies the whole rest of the
function name (though I also like "make_cxx_scope"), and for
"initial_push_namespace_scope", the "initial" modifies "push"; subsequent
pushes reuse the binding level created in the initial push.
Jason