This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATH] fix c/10962, slow lookup_field


Thanks, almost there.

I wouldn't bother with the DECL_DECLARES_TYPE_NON_TEMPLATE_P macro; it
doesn't make the code any clearer.  Just write the test directly in the
function.

Also, we need a more descriptive name than "lang_record_type" for this
struct.  Perhaps sorted_fields_type?

Don't add another blank line before struct lang_type.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]