This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Removing redundant loads


In message <1054256892.21692.93.camel@frodo.toronto.redhat.com>, Diego Novillo 
writes:
 >On Thu, 2003-05-29 at 16:38, law@redhat.com wrote:
 >
 >> Index: tree-ssa.c
 >> ===================================================================
 >> RCS file: /cvs/gcc/gcc/gcc/Attic/tree-ssa.c,v
 >> retrieving revision 1.1.4.81
 >> diff -c -3 -p -r1.1.4.81 tree-ssa.c
 >> *** tree-ssa.c	24 May 2003 13:08:51 -0000	1.1.4.81
 >> --- tree-ssa.c	29 May 2003 19:16:09 -0000
 >> *************** rewrite_stmt (si, block_defs_p, block_av
 >> *** 2107,2116 ****
 >>       fold_stmt (stmt);
 >>   
 >>     /* Step 2.  Check for redundant computations.  Do this optimization onl
 >y
 >> !      for assignments that make no calls and have no aliased nor volatile
 >> !      references and no side effects (i.e., no VDEFs).  */
 >> !   may_optimize_p = !ann->makes_aliased_loads
 >> ! 		   && !ann->makes_aliased_stores
 >>   		   && !ann->has_volatile_ops
 >>   		   && vdefs == NULL;
 >>   
 >> --- 2107,2115 ----
 >>       fold_stmt (stmt);
 >>   
 >>     /* Step 2.  Check for redundant computations.  Do this optimization onl
 >y
 >> !      for assignments that make no calls and have no aliased stores
 >> !      nor volatile references and no side effects (i.e., no VDEFs).  */
 >> !   may_optimize_p = !ann->makes_aliased_stores
 >>   		   && !ann->has_volatile_ops
 >>   		   && vdefs == NULL;
 >>   
 >Jeff,
 >
 >This hunk causes stage1/xgcc to ICE in assign_vars when building
 >rs6000.c.  I'm still not sure why.
 >
 >I'm trying to stabilize the merge and I still have a few regressions to
 >check in x86 and amd64.  I will reverse this hunk temporarily until I
 >fix all the other bits.
I would *much* prefer we understand the PPC failure instead of reverting
the change, even on a temporary basis.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]