This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to use HOST_WIDE_INT_PRINT_DOUBLE_HEX in two places


"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:

| I think the code below should be using HOST_WIDE_INT_PRINT_DOUBLE_HEX
| rather than constructing format specifiers manually.
| 
| The cp/error.c case would be identical.  The c-pretty-print.c case
| currently does not prepend "0x", and it looks deliberate.  But if
| we're talking about "pretty", I think adding "0x" is certainly a
| "prettier" way to represent hex numbers. :-)  And so using the HWI
| macro would change this for the better.
| 
| Bootstrapped on sparc-sun-solaris2.7, no new warnings.
| 
| Ok for mainline?

Yes.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]