This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch installed to concatentate specifiers using HOST_WIDE_INT_PRINT_*


On Fri, May 16, 2003 at 09:01:27PM +0100, Joseph S. Myers wrote:
> On Fri, 16 May 2003, Kaveh R. Ghazi wrote:
> 
> > This patch concatentates format specifiers in files from the config/
> > directory which had been split in deference to K&R C (which we no
> > longer support.)  This should generate marginally smaller code since
> > we're making several fewer function calls in each case.
> 
> Can we establish (and document in codingconventions.html) a convention for 
> whether there should be a space between the string constants and the macro 
> name (that is, whether we use
> 
>   "foo"HOST_WIDE_INT_PRINT_DEC"bar"
> or
>   "foo" HOST_WIDE_INT_PRINT_DEC "bar"

The latter is, IMNSHO, far easier to read, and points up an obvious place
for line breaks as well.

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]