Re: Updated --with-cpu patch, v9

[Richard Sandiford <rsandifo at redhat dot com>]

Daniel Jacobowitz <drow@mvista.com> writes:
> +/* Support for a compile-time default CPU, et cetera.  The rules are:
> +   --with-arch is ignored if -march is specified or a -mips is specified
> +     (other than -mips16).
> +   --with-tune is ignored if -mtune is specified.
> +   --with-abi is ignored if -mabi is specified.
> +   --with-float is ignored if -mhard-float or -msoft-float are
> +     specified.  */
> +#define OPTION_DEFAULT_SPECS \
> +  {"arch", "%{!march=*:%{mips16:-march=VALUE}%{!mips*:-march=VALUE}}" }, \
> +  {"tune", "%{!mtune=*:-mtune=VALUE}" }, \
> +  {"abi", "%{!mabi=*:-mabi=VALUE}" }, \
> +  {"float", "%{!msoft-float:%{!mhard-float:-mVALUE-float}}" }

Hey, this is nice. ;)

Since you check the value of --with-float in config.gcc, would it be
worth checking --with-abi as well?  The possible values are fairly
small (32,n32,o64,64,eabi) and it would catch easy mistakes like
--with-abi=o32.

Hope the patch gets in though.

Richard