This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[libstdc++] Quote LD_RUN_PATH properly


Neil noticed that BSD make was failing to build abi_check, with an error
message involving "+".  Turns out things weren't being expanded properly.
Fixed thusly.  Reproduced on i686/linux using pmake 1.45, and tested the
same way.  Applied to trunk, queued for 3.3.1.

Alexandre tells me that this LD_RUN_PATH setup is wrong, and that we are
in fact way overcomplicating things by abusing libtool.  I believe him,
but I don't have the courage to try and change it.


2003-05-11  Phil Edwards  <pme@gcc.gnu.org>

	* testsuite/Makefile.am:  Properly quote LD_RUN_PATH.
	* testsuite/Makefile.in:  Regenerate.


Index: testsuite/Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/Makefile.am,v
retrieving revision 1.16
diff -u -3 -p -r1.16 Makefile.am
--- testsuite/Makefile.am	26 Apr 2003 04:01:47 -0000	1.16
+++ testsuite/Makefile.am	11 May 2003 23:59:19 -0000
@@ -41,7 +41,7 @@ RUNTESTFLAGS =
 CXX_build = @glibcpp_CXX@ 
 CXX=`echo "$(CXX_build)" | sed 's,gcc/xgcc ,gcc/g++ ,'`
 CXXLINK = \
-	LD_RUN_PATH=${LD_RUN_PATH:+$LD_RUN_PATH:}${glibcpp_builddir}/src/.libs\
+	LD_RUN_PATH=$${LD_RUN_PATH:+$LD_RUN_PATH:}${glibcpp_builddir}/src/.libs\
 	$(LIBTOOL) --tag=CXX --mode=link $(CXX) \
 	$(AM_CXXFLAGS) $(CXXFLAGS) $(LDFLAGS) -o $@
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]