This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add new target: vxworks for xscale


    I don't like this approach.  As a Fortran maintainer, I could surely be 
    presented with patches thought up or adopted by a global write 
    maintainer.  That doesn't mean I'd just forgo my right to review them ...

No, of course not.  And indeed your comments on such a patch should
be given great weight, as Zack's was in my case.  But that doesn't
mean you (or Zack) would have the right to immediately demand they be
reverted without further discussion.  Your (and Zack's) goal should be
to convince the person who applied the patches that they were wrong and
you were right.  That should normally not be hard (and wasn't in
this case, once the discussion occurred).

    Just applying patches written by someone else without review is utterly 
    wrong, in my not so humble opinion.

That's not what happened in this case.  I not only "reviewed" it, but
made significant changes.  I spent a few hours on this patch, in fact,
and a changed a number of things I didn't like.

Zack had more things he didn't like, but before I was willing to automatically
defer to his opinion, I wanted to give the original author a chance to
address them.  Perhaps there were some things that made this method correct
and Zack wrong.  Perhaps not.  But what's wrong with trying to find out?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]