This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: unreviewed patches
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 06 May 2003 22:34:45 +0930
- Subject: Re: unreviewed patches
- References: <20030409025944.GN1189@bubble.sa.bigpond.net.au><20030417222754.GZ1189@bubble.sa.bigpond.net.au><orfznsioi4.fsf@free.redhat.lsd.ic.unicamp.br>
On Tue, May 06, 2003 at 03:21:39AM -0300, Alexandre Oliva wrote:
> On Apr 17, 2003, Alan Modra <amodra@bigpond.net.au> wrote:
>
> >> add_sysrooted_prefix
> >> http://gcc.gnu.org/ml/gcc-patches/2003-03/msg01608.html
>
> > Perhaps I should have explained why I want this one in, although it
> > should stand alone just as a code clean-up.
>
> Actually, I don't like the removal of the arguments. Even though
> they're unused now, they might be useful some day, and they make the
> calls to add_prefix interchangeable with those to
> add_sysrooted_prefix. I don't care all that strongly about keeping
> them as they are, but I'm pretty the odds of the feature you want
> getting it will increase if you split them up :-)
Thanks for commenting. A post in the thread should be as good as
a nag from me, maybe better. :) As far as the arg removal goes,
I still think it's better to not pass args around unnecessarily,
but I'll quite happily commit a patch without that change.
--
Alan Modra
IBM OzLabs - Linux Technology Centre