This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Counter-PATCH (libstdc++-v3, mainline) for: std::_Atomic_swap for i386
- From: Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- To: danny_r_smith_2001 at yahoo dot co dot nz
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Mon, 5 May 2003 17:31:22 -0500 (CDT)
- Subject: Re: Counter-PATCH (libstdc++-v3, mainline) for: std::_Atomic_swap for i386
- References: <200305031018.h43AIg3t027074@latour.rsch.comm.mot.com>
- Reply-to: rittle at labs dot mot dot com
Danny, Thank you for testing in your environment and agreeing to a
replacement patch (I've been looking to kill the special lone use of
_Atomic_swap). Tested in multiple environment as mentioned in the
thread. I added this text and committed to the mainline:
2003-05-05 Loren J. Rittle <ljrittle@acm.org>
(Inspired by an alternate patch from Danny Smith.)
> * include/bits/stl_threads.h (_Atomic_swap): Kill it...
> (_Swap_lock_struct<>): ...and the horse it rode in on.
> * src/globals.cc (_Swap_lock_struct<>): Likewise.
> * include/ext/stl_rope.h (_Rope_RopeRep<>::_M_c_string_lock): New
> member to support...
> * include/ext/ropeimpl.h (rope<>::c_str): Follow *all* memory
> visibility rules related to POSIX threads.
> * testsuite/thread/pthread7-rope.cc: New test.
(Please note that the removed object was not mentioned in the
config/linker-map.gnu, but I'd consider this one of those pesky
effective ABI changes.)