This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Allow "make compare" to use "make gnucompare" automatically
On Sun, 27 Apr 2003, Phil Edwards wrote:
> On Sun, Apr 27, 2003 at 09:36:11AM -0400, Andrew Pinski wrote:
> > I have a small problem, with your patch, it does not match the version I
> > have on my machine (running powerpc-apple-darwin6.5, Mac OS X 10.2.5
> > with
> > the December Developer tools), 2.7.
> >
> > Here is the output of cmp --version:
> > cmp - GNU diffutils version 2.7
>
> Hm. That seems easy enough to fix. Could you try applying this patch,
> regenerating gcc/configure, and seeing whether it helps?
We should be using a feature test here - version tests are for when a
combination of different features in a particular version are wanted, or
where the features or bug fixes that are needed are difficult to test for,
and shouldn't substitute for a feature test where there is a single
well-defined feature that is straighforward to test for.
--
Joseph S. Myers
jsm28 at cam dot ac dot uk