This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add support for profile merging hooks
Zdenek Dvorak wrote:
with it yes; why without? Here is the new version.
sorry I meant --enable-coverage - that tends to stress this more
than the testsuite.
+ static tree build_gcov_merge_fn_type PARAMS ((void));
please don't have this fn, it is inconsistent with the other parts
of build_ctr_info_type and build_ctr_info_value.
Index: gcov-io.h
===================================================================
! #define gcov_var __gcov_gcov_var
Sorry, I missed this the first time, you only need to have an __ to
get it out of the user namespace, repeating gcov makes it
look like the compiler has a stutter!
Index: gcov-io.c
===================================================================
+ #ifdef IN_LIBGCOV
+ struct gcov_var gcov_var;
+ #endif
and I missed that. it is not necessary, you need a
#define GCOV_LINKAGE /*nothing*/
in one of the libgcov.c sections *before* gcov-io.h is #included. See
what happens in coverage.c (of course you'll have to protect the
#define of GCOV_LINKAGE in gcov-io.h
with those changes & successful --enable-coverage, ok.
As with all patches please indicate the target triplet that
you test on, in future.
thanks,
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
The voices in my head said this was stupid too
nathan at codesourcery dot com : http://www.cs.bris.ac.uk/~nathan/ : nathan at acm dot org