Re: RFC: Make a standalone GNU V3 C++ demangler

["H. J. Lu" <hjl at lucon dot org>]

On Thu, Apr 24, 2003 at 01:16:30PM +0200, Carlo Wood wrote:
> On Wed, Apr 23, 2003 at 04:49:20PM -0700, H. J. Lu wrote:
> > Here are ChangeLog entries. Any comments are welcome.
> > 
> > 2003-04-23  Carlo Wood  <carlo at alinoe dot com>
> > 	    H.J. Lu <hjl at gnu dot org>
> > 
> > 	* allocator.h: New C++ file.
> > 	* demangler.cc: Likewise.
> > 	* demangler.h: Likewise.
> > 	* dynstring.h: Likewise.
> 
> Will 'demangler.h' still be installed in a user accessible place?
> 
> > libstdc++-v3/
> > 
> > 2003-04-19  H.J. Lu <hjl at gnu dot org>
> > 
> > 	* include/Makefile.am (bits_headers): Remove
> > 	${bits_srcdir}/demangle.h.
> > 	* include/bits/demangle.h: Removed.
> 
> Because you remove it here.
> 
> > 	* libsupc++/Makefile.am (headers): Add bits/demangle.h.
> 
> This line confuses me - in this patch you removed the source
> code for libstdc++-v3/include/bits/demangle.h, and somewhere else
> you add it as binutils/demangler/demangler.h.  Note the added 'r'.
> 
> As part of which package will this demangler.h be available to
> normal users?
> 
> > 	(install-glibcppinstallHEADERS): Install bits/demangle.h.
> 
> Idem aka the 'r'.
> 

I know it may be confusing. The problem is there is a demangle.h in
include already, which has to be included in the demangler source. To
avoid conflict, I renamed the one from the demangler to demangler.h.
That was before I created a separate demangler source. The symlinks
in libstdc++-v3 look like:

$(LN_S) $(toplevel_srcdir)/demangler/demangler.cc demangle.cc
$(LN_S) $(toplevel_srcdir)/demangler/demangler.h bits/demangle.h

Now there is a separate demangler source. I can use demangle.cc and
bits/demangle.h in it, instead of demangler.cc and demangler.h. Carlo,
if it will make you easier to work on the demangler, I can do something
like

include/bits/allocator.h
include/bits/dynstring.h
include/bits/demangle.h
lib/demangle.cc

in the demangler source tree. In libstdc++-v3, symlinks will be

$(LN_S) $(toplevel_srcdir)/demangler/lib/demangle.cc .
$(LN_S) $(toplevel_srcdir)/demangler/include/bits/demangle.h bits

H.J.