Re: Approval: can I commit this please?

[Geoff Keating <geoffk at geoffk dot org>]

"Kean Johnston" <jkj at sco dot com> writes:

> > Are you sure this won't break all the ports that aren't SCO and don't
> > use GNU ld?
> > The patch also needs a ChangeLog.
> 
> No more than it already breaks them, since they don't know what
> -shared is either, to most linkers, its -s hared, setting the
> start symbol to 'hared'. And yes, I will create a changelog, sorry I
> didn't include one in the mail.

Yes, but are you sure that there's no non-GNU ld that doesn't
understand -shared now?  That seems like a very hard thing to be sure
about.  It might be better if your patch could try -shared and -g one
after the other, or explicitly detect SCO ld, or something.

> How about this:
> 
> 	* configure.in: check to see if we're using GNU ld, and set
>       gcc_cv_ld_is_gny to yes if we are; search for as and ld in
>       /usr/ccs/bin/elf before /usr/ccs/bin; remove dependency on
>       GNU grep by using sed addressed, and cleanup up the check for
>       mixed RO/RW sections.
>       * tlink.c (recompile_files): fixed putenv() arguments.

That looks reasonable.

-- 
- Geoffrey Keating <geoffk at geoffk dot org>