This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Minor tweaks to libiberty's strdup
- From: Roger Sayle <roger at www dot eyesopen dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 14 Apr 2003 11:49:40 -0600 (MDT)
- Subject: Re: [PATCH] Minor tweaks to libiberty's strdup
Hi DJ,
On Mon, 14 Apr 2003, DJ Delorie wrote:
>
> > + #include <ansidecl.h>
> > + #ifdef __STDC__
> > + #include <stddef.h>
> > + #endif
> > +
>
> But, this is the way the other files do it. Except that they use int
> instead of size_t for strlen (except for strstr), and only rarely use
> the PARAMS syntax. Sigh.
Could you comment on Kaveh's recommendation that we should use
ANSI_PROTOTYPES instead of __STDC__?
http://gcc.gnu.org/ml/gcc-patches/2003-04/msg00963.html
I'm not sure of the issues, but I am happy to submit patches to
standardize some of these features (size_t vs int for strlen etc...)
once I know what's preferred.
Roger
--