This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GCC 3.3: inline-asm problems
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: Richard Henderson <rth at redhat dot com>, gcc at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: 21 Mar 2003 13:20:28 -0800
- Subject: Re: GCC 3.3: inline-asm problems
- Organization: CodeSourcery, LLC
- References: <200303211930.h2LJURtW002846@warlock.codesourcery.com> <20030321194510.GF25708@kam.mff.cuni.cz> <20030321202918.GC8150@redhat.com> <20030321205259.GJ25708@kam.mff.cuni.cz>
- Reply-to: mark at codesourcery dot com
On Fri, 2003-03-21 at 12:52, Jan Hubicka wrote:
> > On Fri, Mar 21, 2003 at 08:45:10PM +0100, Jan Hubicka wrote:
> > > What about making the error message of ellimination to look like error
> > > message of reload? (ie when the instruction is bogus do not abort but
> > > spit out something like "inconsistent asm operand constraints").
> >
> > I've mentioned this before. I think it's a good idea.
This new function needs a comment.
> + static void
> + instantiate_virtual_regs_lossage (insn)
> + rtx insn;
> + {
> + if (asm_noperands (PATTERN (insn)) >= 0)
> + {
> + error_for_asm (insn, "impossible constraint in `asm'");
> + delete_insn (insn);
> + }
> + else
> + abort ();
> + }
> + /* We may detect invalid asm statements and deleted them. */
/* We may have detected and deleted invalid asm statements. */
would be more grammatical.
The patch is fine; thanks!
That ought to knock down a couple of PRs...
--
Mark Mitchell <mark at codesourcery dot com>
CodeSourcery, LLC