This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: PATCH to diagnostic.c:text_specifies_location


Jason Merrill wrote:-

> But using a null pointer requires null pointer checks everywhere.  I think
> setting up a special value once is safer.

I think you'd find the fall-back (if you removed it) is
main_input_filename, but I could be wrong.

> i.e. "<built-in>"?  I have no idea.  I seem to have put in "<internal>" in
> 1993; I probably wasn't aware of the precedent for <built-in>, which at
> that time was only handled in make_node.

<built-in> is for diagnostics only, intended for things like "macro foo
redefined, previous definition was here: <builtin-in>".  rth or whoever
did the string comparison (CVS blame shows rth, but that doesn't mean
it's his) shouldn't have put it there is the first place.  It's ugly and
it's a bug, since <builtin-in> is internationalized.

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]