This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Improve x86-64 prologues and epilogues


On Tue, Mar 18, 2003 at 07:09:02PM +0100, Jan Hubicka wrote:
> *************** ix86_compute_frame_layout (frame)
> *** 4605,4610 ****
> --- 4611,4649 ----
>     frame->nregs = ix86_nsaved_regs ();
>     total_size = size;
>   
> +   if (!optimize_size && !cfun->machine->use_fast_prologue_epilogue_initialized)
> +     {
> +       int count = frame->nregs;
> + 
> +       cfun->machine->use_fast_prologue_epilogue_initialized = 1;

This is technically incorrect.  You're making the decision
based on the first round of reload.  More registers may be
spilled after this.

You're better off doing away with the initialized flag and
checking reload_in_progress.

The rest of it looks reasonable.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]