This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR c/9853
On Wed, Mar 12, 2003 at 06:20:53PM -0800, Richard Henderson wrote:
> I didn't like Glen's patch as much. I was halfway through looking
> at it, and thinking, "aren't some pushes needed here", when I
> remembered your message.
>
> I can see the push/pop version using less stack in cases that are
> nested farther than this.
Well, while I was tracing through the code, I noticed expand_decl_init
doesn't really allocate temporaries itself... It just calls expand_assignment.
Now, if you look at expand_assignment, almost every code path is already
wrapped in push/free/pop triples so calling free_temp_slots in expand_decl_init
seemed redundant. Of course, I really don't understand how this stuff is
intended to work, so if you think push/pop is better I won't be complaining.
:)
- glen