Re: Squelch HOST_FLOAT_WORDS_BIG_ENDIAN

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Zack" == Zack Weinberg <zack at codesourcery dot com> writes:

FYI there's a java-patches list.

Zack> I would appreciate a second opinion on the changes to gjavah.c,
Zack> javaop.h, and jcf-dump.c.

Zack> Hexadecimal floating constants are not yet a feature of standard
Zack> C++, but g++ accepts them, and gjavah-generated headers are
Zack> probably going to be used with g++, so that should be fine.

These headers can only be used with g++, so that isn't a problem.

Zack> Bootstrapped i686-linux without regressions, and I did a cursory test
Zack> to make sure jcf-dump did something plausible.  I wasn't able to get
Zack> gjavah to exercise this code.  I don't know if this stuff gets tested
Zack> by the libjava testsuite.

jcf-dump doesn't have any tests.

gjavah is tested when building libgcj from scratch.  All the required
headers are built and then a fair number of them are used for other
parts of the build.  You could try `make header-check' in the target
build directory, but I haven't run that target in a long time and I
really have no idea if it works at all.

I doubt the libgcj build (or test suite for that matter) would notice
if the generated values were incorrect.  That's because it would
require CNI code to be using these values, and as far as I know there
is none in the library (and there aren't any CNI tests aside from the
library itself).

Take a look at Double.h in the build tree (.../libjava/java/lang/Double.h).
That should have some jdouble constants in it.  The code in question
should only be exercised when generating CNI headers for classes that
have float or double constants ("static final float foo = 0.234234").


Is there no way to get jcf-dump to print a non-hex value?  This
program is used for inspecting class files.  Having hex output is less
useful than printing the constant the way one would expect.

Tom