This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix for AIX bootstrap failure
> Andreas Jaeger <aj at suse dot de> writes:
>
> > Jan Hubicka <jh at suse dot cz> writes:
> >
> >> Thanks. I wonder why this does not happen on i386 at all, but anyway
> >> it is incorrect to keep pointers into local decls without preventing
> >> them from being garbage collected.
> >>
> >> OK for mainline?
>
> Yes, if you make Andreas's suggested changes, and:
>
> > I suggest:
> >
> > /* The known declarations must not get garbage collected. Callgraph
> > datastructures should not get saved via PCH code since this would
> > make it difficult to extend into intra-module optimizer later. So
> > we store only the references into the array to avoid the garbage
> > collector from doing its job. */
>
> This is still not grammatical English; you can't use 'avoid' like
> that, and 'doing its job' implies functioning correctly, which it
> isn't. "to prevent the garbage collector from deleting live data" is
> better.
>
> I don't understand what you're trying to say, though. Why is it
> undesirable to preserve the (partial) call graph in a pch dump?
Because in the case we will use PCH code to preserve trees for whole
program compilation, we want to save the callgraph and local function
information separately, so we can fetch it first, propagate global
infromation and then use PCH code to load function bodies as needed.
Honza
>
> zw