This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH for 3.4, committed] Fix PR9188

From: Kriang Lerdsuwanakij <lerdsuwa at users dot sourceforge dot net>
To: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 07 Mar 2003 22:25:39 +0700
Subject: Re: [C++ PATCH for 3.4, committed] Fix PR9188
References: <Pine.LNX.4.33.0303061916550.9756-100000@kern.srcf.societies.cam.ac.uk>

Joseph S. Myers wrote

Why haven't you added a testcase for this?  Patches need either testcases,
or justification for their absence (especially in cases like this where it
looks like a testcase ought to be easy, using dg-bogus "expected
expected").

Sorry I forgot to mention this in the patch. I felt it's not useful to have a testcase for this one. The patch only changed an error message so a testcase could only detect broken diagnostics for this particular case but doesn't find duplicate message in general.

--Kriang

References:
- Re: [C++ PATCH for 3.4, committed] Fix PR9188
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]