This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: darwin and pic/dynamic-no-pic
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Andrew Pinski <apinski at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Dale Johannesen <dalej at apple dot com>, Sanjay Patel <spatel at apple dot com>, Kay Khoo <kkhoo at apple dot com>
- Date: Wed, 05 Mar 2003 12:34:16 -0500
- Subject: Re: darwin and pic/dynamic-no-pic
- References: <DB1D0118-4ECA-11D7-BFFD-00039372607E@apple.com>
The rs6000.* changes look okay. An Apple maintainer should okay
the darwin.* changes.
Why is MACHO_DYNAMIC_NO_PIC_P() a macro with parentheses but no
arguments?
And please correct the formatting, e.g.,
+#if TARGET_MACHO
+ if ( MACHO_DYNAMIC_NO_PIC_P ())
---^--- extra space
+ output_asm_insn (\"{liu|lis} %L0,ha16(%2+4)\", operands);
+ else
+#endif
Thanks, David