Re: Call for testers: libiberty/physmem.c

["Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>]

 > From: DJ Delorie <dj at redhat dot com>
 > 
 > > +#if HAVE_TABLE
 > > +  {
 > > +    struct tbl_vmstats vmstats;
 > 
 > Call me paranoid, but can we put a HAVE_SYS_TABLE_H around that also?
 > "table" doesn't seem unambiguous enough to give me a warm-and-fuzzy
 > about false positives.
 > 
 > And we should check for machine/hal_sysinfo.h separately.  Linux has
 > sys/sysinfo.h but not machine/hal_sysinfo.h.  We'd need to use the
 > "hal" define to protect as well, else we'd try to access 'table' on
 > linux (it doesn't have one).

I'd like to act as the central clearing house for physmem.c patches
for the first week or so.  I'm receiving lots of suggestions and
sometimes more than one approach for each platform and I'd like to
opportunity to pick each case opting for simplicity and thorough
checks as DJ mentioned.

Keep 'em coming!

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi at caip dot rutgers dot edu