Re: Fix for configuring targets that need extra flags

[Sean McNeil <sean at mcneil dot com>]

Got it.  No diff Changelog entry.

The reason I use CFLAGS_FOR_TARGET is that CPPFLAGS_FOR_TARGET didn't
seem to be part of the collection of flags that gets passed through the
recursive make process.  At least not at the time I did this (which was
quite a while ago).  I haven't looked at it anytime recently.

I will look at it, patch the Makefile.tpl instead and resubmit.

Sean

On Thu, 2003-02-20 at 13:53, DJ Delorie wrote:
> > +           CPPFLAGS="$(CFLAGS_FOR_TARGET)"; export CPPFLAGS; \
> > +           CPPFLAGS="$(CFLAGS_FOR_TARGET)"; export CPPFLAGS; \
> 
> Shouldn't these be $(CPPFLAGS_FOR_TARGET)?  CFLAGS includes options
> that the preprocessor may not support.  Otherwise, there would be no
> need to have a separate CPPFLAGS in the first place.
> 
> Although, I suppose if we're building target libraries, we know we're
> using gcc, and gcc allows this anyway, so I guess this is the easier
> solution.
> 
> Note that Makefile.in is a generated file.  You need to edit
> Makefile.tpl and regenerate Makefile.in from that.
> 
> Also, in the future, please don't make the ChangeLog entry part of the
> diff.  It often will not apply due to other committed changes.  Just
> paste it in as part of the text.