This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: Re: rfc: auto-casted vector types


The code part of this is OK (although your mailer has word-wrapped the
patch and I think has played with the whitespace); Zack has already
commented on the docs.
Blame apple mail ;-).  My linux box is en-route to a tropical island.


+   /* FIXME: We assume V2SI is the opaque type, so we accidentally
+      allow inter conversion to and from V2SI modes.  We could use
+      V1D1, and rewrite <spe.h> accordingly.  */
+   return t1 == V2SI_type_node || t2 == V2SI_type_node;
... I was kind of hoping you could fix this.  It's the sort of thing
that becomes increasingly hard to fix over time, because people start
to write code that (perhaps unknowingly) depends on it.

It could be fixed by having a separate opaque_type_node which has the
same contents as *V2SI_type_node but a different address.
Tell you what, I'll do it tomorrow, as I'm knee deep in another patch. OK? :-)

Aldy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]