This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix memory overflow in mainline
- From: Jan Hubicka <jh at suse dot cz>
- To: Roger Sayle <roger at www dot eyesopen dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 17 Feb 2003 16:39:57 +0100
- Subject: Re: Fix memory overflow in mainline
- References: <Pine.LNX.4.44.0302170746320.29440-100000@www.eyesopen.com>
>
> Jan Hubicka wrote:
> > I will install this as obvious once machines start up.
> >
> > Mon Feb 17 13:45:52 CET 2003 Jan Hubicka <jh@suse.cz>
> > * recog.c (split_all_insns): Fix memory overflow.
>
> A good try but this is wrong. sbitmap_copy will copy the
> number of bits in the destination, as the source has less
> words this will again read beyond the end of the blocks array.
>
> What we really need is an sbitmap_resize. If this function
> also takes an argument that specifies the initial value of
> the new bits, it'll also avoid the loop immediately following
> in split_all_insns which sets them individually.
Alternativly the whole thing can be reorganized to simply use dirty
flags of BBs...
I don't have time to do that right now, unfortunately...
Honza
>
> Roger
> --
> Roger Sayle, E-mail: roger@eyesopen.com
> OpenEye Scientific Software, WWW: http://www.eyesopen.com/
> Suite 1107, 3600 Cerrillos Road, Tel: (+1) 505-473-7385
> Santa Fe, New Mexico, 87507. Fax: (+1) 505-473-0833