This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [3.2/3.3/mainline] Fix alignment of SSE arguments


> On Mon, Feb 10, 2003 at 01:29:24PM +0100, Jan Hubicka wrote:
> > 	* i386.c (contains_128bit_aligned_vector_p): New function
> > 	(ix86_function_arg_boundary): Properly align vector modes.
> 
> You are sure that this is compatible with icc for all
> of the relevant cases?

It is not, since older ICC passes arguments memory (from what you said)
and newer in up to 3 registers (from my testcase), so it is impossible
to be compatible with.   But except that I've verified that when
argument is passed in memory, it is padded in the same way as GCC does.
It happens for both registers and structures.

I hope this is enought explanation so I am taking it as a approval.  We
may decide what to do with the ICC ABI change next.

Honza
> 
> If so, I guess this is ok.  And while an ABI change,
> it's not one that affects existing users, because
> at the moment they get crashes.
> 
> 
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]