This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Mainline bootstrap failure on alphaev67-dec-osf5.1
- From: Roger Sayle <roger at www dot eyesopen dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Sat, 8 Feb 2003 11:27:36 -0700 (MST)
- Subject: Re: Mainline bootstrap failure on alphaev67-dec-osf5.1
On Wed, 5 Feb 2003, Kaveh R. Ghazi wrote:
> Yes this is exactly why lbasename was introduced. IMHO, with
> appropriate testing this change is "obvious".
I've commited the following patch to mainline CVS, after testing with
a complete bootstrap and "make -k check", all languages except Ada and
treelang, on i686-pc-linux-gnu with no new regressions. It also fixes
the alphaev67-dec-osf5.1 bootstrap failure at this point, but as I've
mentioned elsewhere Tru64 still has bootstrap problems.
> PS: there is also a basename call in fixinc/fixfixes.c. The fixincl
> directory doesn't use -Werror (yet) but might in the future if I can
> work everything out.
I've checked this call and the argument based to "basename" isn't const,
so this doesn't produce a warning, and it shouldn't affect our ability
to apply -Werror to this directory in the future. Playing safe, I've
left things as they are.
Many thanks again,
2003-02-08 Roger Sayle <roger@eyesopen.com>
* jcf-io.c (java_or_class_file): Use libiberty's lbasename
instead of basename to avoid compiler warnings on Tru64.
Index: jcf-io.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/jcf-io.c,v
retrieving revision 1.42
diff -c -3 -p -r1.42 jcf-io.c
*** jcf-io.c 22 Jan 2003 20:51:55 -0000 1.42
--- jcf-io.c 8 Feb 2003 04:29:12 -0000
*************** compare_path (const void *key, const voi
*** 292,298 ****
static int
java_or_class_file (const struct dirent *entry)
{
! const char *base = basename (entry->d_name);
return (fnmatch ("*.java", base, 0) == 0 ||
fnmatch ("*.class", base, 0) == 0);
}
--- 292,298 ----
static int
java_or_class_file (const struct dirent *entry)
{
! const char *base = lbasename (entry->d_name);
return (fnmatch ("*.java", base, 0) == 0 ||
fnmatch ("*.class", base, 0) == 0);
}
Roger
--
Roger Sayle, E-mail: roger@eyesopen.com
OpenEye Scientific Software, WWW: http://www.eyesopen.com/
Suite 1107, 3600 Cerrillos Road, Tel: (+1) 505-473-7385
Santa Fe, New Mexico, 87507. Fax: (+1) 505-473-0833