Re: fix Werror failures on alpha-linux

["Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>]

Richard - this hunk:

 > * fixinc/Makefile.in (FL_LIST): Add $($@-warn) hook.
 > 
 > @@ -29,7 +29,7 @@ SHELL=@SHELL@
 >  # in the kernel.  So, we use `echo' instead. 
 >  STAMP = echo timestamp >
 >  
 > -FL_LIST = $(CFLAGS) $(CPPFLAGS) $(WARN_CFLAGS)
 > +FL_LIST = $(CFLAGS) $(CPPFLAGS) $(WARN_CFLAGS) $($@-warn)
 >  FIXINC_DEFS = -DIN_GCC -DHAVE_CONFIG_H $(FL_LIST) $(INCLUDES)
 >  
 >  # Directory where sources are, from where we are.
 > 
 > 

causes a bootstrap failure if your stage1 compiler is cc because
-Wno-error is passed to the compiler without regard to whether or not
gcc is being used.

I'm not sure why you went down this road in the first place, the
-Werror stuff is only used in stage2 or later and the fixincl stuff is
built in stage1.  (Unless you set WERROR for a cross-compile?)

Anyway, the other thing that puzzles me is why $($@-warn) is needed in
the first place here.  I thought $(WARN_CFLAGS) would contain
GCC_WARN_CFLAGS which should have expanded to the "right thing" if
your stage1 compiler was gcc.  Perhaps the expansion is getting lost
when going into the fixinc Makefile.

Ideas?  Zack?

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu