This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to enable -Werror [take 2]


 > From: David Edelsohn <dje@watson.ibm.com>
 > 
 > 	Please do not make -Werror the default, I still see warnings for
 > native builds on AIX.  Cross-compilation is not the same as testing on the
 > native platform.  If you want to set that for certain platforms, possibly
 > in config.gcc, go head.  Your patch will cause bootstrap failures on
 > primary platforms

David - the point of -Werror is to avoid regressions being introduced.
If it's enabled for just a small subset of platforms, then we'll get
regressions from the people who's testing platform is one of those not
included.  Everybody has to have some skin in the game for this to
work.

You haven't said what warnings you still get on AIX.  My patch
includes a few per-file bypasses for files that are hard to fix.  It's
possible that your warnings are already caught and ignored.  If not,
then tell me what they are and we can try to fix them or bypass those
files as a last resort.  Most of the time, these fixes are a one-line
change.

 > and I will immediately ask for the patch to be reverted.
 > David

I really wish your reaction would have been "... and I will
immediately fix the warning(s)."

		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]