This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [3.4] DESTDIR support completed
Hi,
Benjamin Kosnik <bkoz@redhat.com> writes:
> On Thu, 09 Jan 2003 08:55:10 +0100
> Andreas Jaeger <aj@suse.de> wrote:
>
>>> libstdc++ folks, can you please comment on this?
>
> Sorry for this delay. I had not realized there was a libstdc++ component
> to this patch.
>
> Instead of doing
>
> $(DESTDIR)${gcc_include_dir} in all of the install routines (over ten)
> why don't you just do:
>
> gxx_include_dir = $(DESTDIR)@gxx_include_dir@
>
> And set it in one place?
>
> What's this for, anyway?
It depends on whether 'gxx_include_dir' is supposed to be able to be
over-ridden by the user (like CFLAGS, or prefix or exec_prefix).
If it is an internal temporary for convenience, then what you suggest
is perfectly fine. If
make gxx_include_dir=/foo install
is supposed to be supported, then it should act like 'prefix' and
'bindir' and 'libdir' and the rest of them. Each use of such
variable in an "install" context should be adorned with $(DESTDIR).
- Hari
--
Raja R Harinath ------------------------------ harinath@cs.umn.edu