This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [MIPS patch] fix warning for -membedded-pic
- From: cgd at broadcom dot com
- To: "Richard Henderson" <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org,echristo at redhat dot com
- Date: 04 Dec 2002 14:10:31 -0800
- Subject: Re: [MIPS patch] fix warning for -membedded-pic
- References: <yov5r8cxlgrn.fsf@broadcom.com><20021204214234.GF13079@redhat.com>
At Wed, 4 Dec 2002 13:42:34 -0800, Richard Henderson wrote:
> On Wed, Dec 04, 2002 at 11:34:52AM -0800, cgd@broadcom.com wrote:
> > - "%($LF%= = . + 8\;bal\\t$LF%=\;la\\t%0,%1-$LF%=%)\;addu\\t%0,%0,$31"
> > + "%($LF%= = . + 8\;bal\\t$LF%=\;nop;la\\t%0,%1-$LF%=%)\;addu\\t%0,%0,$31"
> > [(set_attr "type" "call")
> > (set_attr "mode" "none")
> > (set_attr "length" "16")])
>
> Need to increase the size of the pattern by 4 as well.
*sigh* Sorry! (mmm, code review.)
Fixed w/ patch below.
cgd
===================================================================
2002-12-04 Chris Demetriou <cgd@broadcom.com>
* config/mips/mips.md (get_fnaddr): Correct length attribute.
Index: config/mips/mips.md
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/mips/mips.md,v
retrieving revision 1.151
diff -u -p -r1.151 mips.md
--- config/mips/mips.md 4 Dec 2002 19:39:55 -0000 1.151
+++ config/mips/mips.md 4 Dec 2002 22:09:11 -0000
@@ -10043,7 +10043,7 @@ ld\\t%2,%1-%S1(%2)\;daddu\\t%2,%2,$31\\n
"%($LF%= = . + 8\;bal\\t$LF%=\;nop;la\\t%0,%1-$LF%=%)\;addu\\t%0,%0,$31"
[(set_attr "type" "call")
(set_attr "mode" "none")
- (set_attr "length" "16")])
+ (set_attr "length" "20")])
;; This is used in compiling the unwind routines.
(define_expand "eh_return"